Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor: add confirmation prompt when executing clear editor history #12506

Merged
merged 3 commits into from
May 10, 2023

Conversation

souravghosh01
Copy link
Contributor

What it does

It adds a confirmation prompt when executing clear editor history
fixes #12496

Recording

Review checklist

Reminder for reviewers

@souravghosh01 souravghosh01 changed the title Fix/clear history editor: add confirmation prompt when executing clear editor history May 9, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 👍

In order to accept your changes please be sure to sure to sign the eclipse contributor agreement (eca) with the same email as your authorship.

@souravghosh01
Copy link
Contributor Author

souravghosh01 commented May 9, 2023

@vince-fugnitto thank you so much for your suggestion. I have already signed the ECA and made the changes.

Signed-off-by: souravghosh01 <samghosh878@gmail.com>
@vince-fugnitto vince-fugnitto added ui/ux issues related to user interface / user experience editor issues related to the editor labels May 10, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you for your first contribution!

@vince-fugnitto vince-fugnitto merged commit 4c78d68 into eclipse-theia:master May 10, 2023
@vince-fugnitto vince-fugnitto added this to the 1.38.0 milestone May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor issues related to the editor ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

editor: add confirmation prompt when executing clear editor history
2 participants